jzoldak commented 7 years ago

The listen port syntax was changed in Twisted version 16.6.0, see twisted PR #610.

This PR is an updated version of #735:

fixes the underlying issue
scoped to only this issue
all tests are passing

@glyph Please take a look.

codecov-io commented 7 years ago

Codecov Report

Merging #736 into master will increase coverage by <.01%. The diff coverage is 100%.

@@            Coverage Diff            @@
##           master    #736      +/-   ##
=========================================
+ Coverage    99.6%   99.6%   +<.01%     
=========================================
  Files          79      79              
  Lines        5564    5565       +1     
  Branches      784     784              
=========================================
+ Hits         5542    5543       +1     
  Misses         10      10              
  Partials       12      12

Impacted Files	Coverage Δ
mimic/tap.py	`100% <100%> (ø)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4fcbbed...f4392db. Read the comment docs.

frzb commented 7 years ago

@glyph or who else takes care: Please merge this PR for this critical issue which renders Mimic at HEAD currently unusable. :pray:

rackerlabs / mimic

Specify the listen port in Twisted's required format #736

Codecov Report