search

rackerlabs / otter

Rackspace Auto Scale
http://www.rackspace.com/cloud/auto-scale/
Other
53 stars 27 forks source link

Delete server after CLB Not Found error while adding the node? #1305

Closed radix closed 9 years ago

radix commented 9 years ago

The behavior of the legacy worker is to delete the server and all other node associations it has when there's a 404 from adding it to a CLB.

The behavior of Convergence is to fail the convergence and (soon) put the group into ERROR state, while leaving the server there.

This behavior is tested with test_group_with_invalid_load_balancer_among_multiple_load_balancers in in test_system_integration_lbaas.py.

radix commented 9 years ago

I'm actually having second thoughts and thinking we should just leave everything as-is. As long as we put the group into ERROR and emit an event on cloud feeds the user should be able to rectify it themselves.

manishtomar commented 9 years ago

I think putting it in ERROR with info in cloud feeds is a better approach. We should probably document this as a behavioral change in convergence.

manishtomar commented 9 years ago

Added doc change https://github.com/rackerlabs/otter/wiki/User-facing-convergence-changes#behavioral-changes. This has been in code for quite sometime.

Closing

radix commented 9 years ago

Thanks :)