search

rackerlabs / otter

Rackspace Auto Scale
http://www.rackspace.com/cloud/auto-scale/
Other
53 stars 27 forks source link

SelfHeal service refactoring #1934

Closed manishtomar closed 7 years ago

manishtomar commented 7 years ago

Separate out locking from SelfHeal service and put it as functions in otter.util.zk. This way it can be used to implement https://github.com/rackerlabs/autoscaling-chef/issues/833 which has similar pattern as SelfHeal service: call a function if it has the lock on timely basis.

codecov-io commented 7 years ago

Current coverage is 92.48% (diff: 97.33%)

Merging #1934 into master will increase coverage by 0.02%

@@             master      #1934   diff @@
==========================================
  Files            83         83          
  Lines          7435       7456    +21   
  Methods           0          0          
  Messages          0          0          
  Branches       1010       1013     +3   
==========================================
+ Hits           6875       6896    +21   
  Misses          463        463          
  Partials         97         97

Powered by Codecov. Last update abab933...e770ff5

manishtomar commented 7 years ago

jenkins please run integration tests

manishtomar commented 7 years ago

jenkins please run integration tests

manishtomar commented 7 years ago

jenkins please run integration tests

manishtomar commented 7 years ago

@glyph review please.