search

rackerlabs / repose

The powerful, programmable, API Middleware Platform
http://www.openrepose.org/
Other
339 stars 103 forks source link

REP-7438 Updated some references to repose-valve #1997

Closed adrianjgeorge closed 6 years ago

dmnjohns commented 6 years ago

It looks like the repose role for the performance tests wasn't updated here? At a minimum, the following line will need to be updated: https://github.com/rackerlabs/repose/blob/master/repose-aggregator/tests/performance-tests/src/performanceTest/resources/roles/repose/tasks/install_repose.yml#L88

wdschei commented 6 years ago

The package name change from repose-valve to just repose should probably be in the upgrade guide too. I know it is in the recipe, but not everyone is going to go look there when they are just upgrading from valve v8.x to v9.x.

adrianjgeorge commented 6 years ago

It looks like the repose role for the performance tests wasn't updated here? At a minimum, the following line will need to be updated: https://github.com/rackerlabs/repose/blob/master/repose-aggregator/tests/performance-tests/src/performanceTest/resources/roles/repose/tasks/install_repose.yml#L88

I'm not certain i see what this line is doing, so i wouldn't mind a hand fixing it

dmnjohns commented 6 years ago

It looks like the repose role for the performance tests wasn't updated here? At a minimum, the following line will need to be updated: https://github.com/rackerlabs/repose/blob/master/repose-aggregator/tests/performance-tests/src/performanceTest/resources/roles/repose/tasks/install_repose.yml#L88

I'm not certain i see what this line is doing, so i wouldn't mind a hand fixing it

The gist of it is that line is looking for the repose-valve.deb file in a specific directory. The task then installs that package. The way it locates the correct package file is to get all the files in the directory (repose_packages.files), look at the path of each file (map(attribute='path')), select the paths matching a pattern (select('match', '.*valve.*')), creating a list of the results (list), taking the first item in that list since we assume there is only one item (first), then stripping the path of everything except the filename (basename).

Oh, and it is using Jinja2 template processing. That's where the Jinja2 filters (e.g., select(..., ...)) are coming from.

From a view further out, that task is part of installing Repose from a local package, which is part of the process to build Repose once, pass around the artifacts, and install on all performance test nodes.