Runtime improvements for config loading/reloading tests

rackerlabs / repose

The powerful, programmable, API Middleware Platform

http://www.openrepose.org/

Other

338 stars 103 forks source link

Runtime improvements for config loading/reloading tests #2044

Closed pglass closed 5 years ago

pglass commented 5 years ago

This removes or replaces some hardcoded sleeps in the TransitionBadToGoodConfigsTest and TransitionGoodToBadConfigsTest.

I recorded the runtimes before/after these changes in the commit messages, so please look through those. Adding up the differences for the modified tests, this saved 2 minutes out of about 19 minutes on my laptop.

Before: 18m48s
After: 16m42s

pglass commented 5 years ago

Not a worthwhile difference on Jenkins: https://jenkins.openrepose.org/job/repose-gradle-pull_request-core/70/testReport/features.core.configloadingandreloading/history/ and it actually took a bit longer than usual for these tests. I'm wondering if the waits take longer than the sleeps they replaced.

adrianjgeorge commented 5 years ago

Could just be noisy neighbor or the particular slave you ended up on.

adrianjgeorge commented 5 years ago

Retest this please

pglass commented 5 years ago

Whoo, so build 74 is the fastest it's ever been: https://jenkins.openrepose.org/job/repose-gradle-pull_request-core/74/testReport/features.core.configloadingandreloading/history/

adrianjgeorge commented 5 years ago

Seems like there are improvements then, and it was just a cloud resource problem on the first run.