rackerlabs / repose

The powerful, programmable, API Middleware Platform
http://www.openrepose.org/
Other
338 stars 103 forks source link

REP-7721: Cleaning up sleeps in functional tests #2049

Closed pglass closed 5 years ago

pglass commented 5 years ago

This cleans up nearly all of the unnecessary sleeps in the functional tests.

pglass commented 5 years ago

These tests were failing in Jenkins after replacing sleeps, so I reverted those changes.

pglass commented 5 years ago

Oh, actually the keystone v2 versions of those tests were failing as well. I'll wait for Jenkins to finish and revert those as well (curious if they still fail on a retest).

pglass commented 5 years ago

There's also a features.core.valveselfconfigure.RuntimeSysmodChangesTest that seems flaky with my new changes. It's failed twice in the past 20 runs or so, and both failures were on this PR: https://jenkins.openrepose.org/job/repose-gradle-pull_request-core/86/testReport/junit/features.core.valveselfconfigure/RuntimeSysmodChangesTest/history/

I'll revert changes for that test for now, and I'll make a note on the JIRA about the tests where my log searches didn't quite work out.

pglass commented 5 years ago

retest this please