search

racket / docker

Docker images for various Racket versions
MIT License
62 stars 17 forks source link

Note: git disappeared from images #59

Closed pmatos closed 3 years ago

pmatos commented 3 years ago

After the last merges, git which used to be installed in the image is not anymore. This is not a problem per-se as I can install it myself but just a note that more builds will break if they assume git is preinstalled.

Bogdanp commented 3 years ago

This is expected since we switched from the buildpack-deps base image to debian:stable-slim to reduce image size. I think the breakage is worth it because the image size gains are significant and most (all?) downstream failures caused by this should be caught at image build time. My view is also that this isn't exactly "breakage" either, since the only thing guaranteed to be distributed w/ these images should be Racket. That said, I wouldn't be opposed to switching back if this causes too much pain for folks.

pmatos commented 3 years ago

Not at all... I am happy with the changes - but I just wanted to add a note here about it in case these side effects hadn't been obvious when the change was made. I will change the title and close the bug.

pmatos commented 3 years ago

@Bogdanp but maybe the README shouldn't reference buildpack-deps as a base any more.

Bogdanp commented 3 years ago

Ah, that's a good point. I forgot to update the README. I'll go ahead and do that now.