search

racket / drracket

DrRacket, IDE for Racket
http://www.racket-lang.org/
Other
448 stars 95 forks source link

Style the clickable “...” in the “arguments...:“ part of error messages to be more obviously clickable #390

Open gfbee opened 4 years ago

gfbee commented 4 years ago

I have forgotten and rediscoverd this multiple times, and (some time ago) at least one person on the slack asked how to see the apparently unavailable elided arguments. Maybe we can also change it to something other than ellipsis since in non-menu contexts it doesn't suggest further interaction (and also it's not for the menu convention of meaning it will involve further interaction).

The edit just now changed the title to show the actual format “...:”. That I thought it was “:...” emphasizes the issue, since the “...” appears to say keep reading, the arguments are still to come after the “:”.

rfindler commented 4 years ago

What about an underline appearing when you mouse over it?

On Fri, Jun 5, 2020 at 12:11 PM gfbee notifications@github.com wrote:

I have forgotten and rediscoverd this multiple times, and (some time ago) at least one person on the slack asked how to see the apparently unavailable elided arguments. Maybe we can also change it to something other than ellipsis since in non-menu contexts it doesn't suggest further interaction (and also it's not for the menu convention of meaning it will involve further interaction).

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/racket/drracket/issues/390, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADBNMBNQO2P74DM4FTHWGLRVERKXANCNFSM4NULC4UA .

gfbee commented 4 years ago

That seems barely more discoverable.

rfindler commented 4 years ago

Suggestions welcome! :)

jackfirth commented 4 years ago

Making the dots blue instead of red might help? So they look like a clickable link.

gfbee commented 4 years ago

Adding a space before the dots and moving them after the colon (or just removing the colon) would be good. Except that might interfere with any code thats been parsing the message to extract information. Although that might not be a problem if the change happens near where the actual display in DrRacket happens, in which case we can reconsider dots entirely.

rfindler commented 4 years ago

The dots are part of the formatting rules from the error message conventions.

spdegabrielle commented 4 years ago

https://docs.racket-lang.org/reference/exns.html?q=error#%28part._err-msg-conventions%29