search

racket / drracket

DrRacket, IDE for Racket
http://www.racket-lang.org/
Other
454 stars 93 forks source link

clarify docs for add-online-expansion-handler #401

Closed maueroats closed 4 years ago

maueroats commented 4 years ago

rephrase docstring for add-online-expansion-handler and add-online-expansion-monitor

rfindler commented 4 years ago

I made two little comments -- happy to make those changes myself if you'd prefer and then just merge.

Thanks!

samth commented 4 years ago

@rfindler if you wan to make an actual edit to the code, you can click the +- button while you're typing the comment, and offer a suggestion which can be incorporated directly in the web interface.

rfindler commented 4 years ago

Nice! Thanks, @samth . (Someone should build the docs and look at the output before pushing probably, tho.)

maueroats commented 4 years ago
  1. Confirmed that the docs render ok.
  2. I see what @racket[_id] is supposed to do, but in my local install, both @racket[_id] and @racket[id] produce the same HTML (a span with class="RktVar"). If you think all of the functions' formal parameters should have underscores in front of their symbols, then this PR could get bigger to make the edits. I'm not undoing your edit, just wondering.
rfindler commented 4 years ago

Oh, my mistake on the _! I was confused -- id is already part of the reader so the rendering is automatic. Sorry about that.