search

racket / drracket

DrRacket, IDE for Racket
http://www.racket-lang.org/
Other
447 stars 94 forks source link

Handle drscheme:opt-out-toolbar-buttons correctly #449

Closed mikesperber closed 3 years ago

mikesperber commented 3 years ago

Either of drscheme:opt-out-toolbar-buttons / drracket:opt-out-toolbar-buttons can be used to turn off the opt-out buttons. The way it was implemented, you needed both. Unbreak.

rfindler commented 3 years ago

I think that it needs to be something more like "replace #f with '() and then do an append". That is, if drr is #f and drs is a list of useful things, we want the list of useful things.

rfindler commented 3 years ago

Oh actually, I think we want to choose either drr or drs (preferring the drr ones).

mikesperber commented 3 years ago

Oh actually, I think we want to choose either drr or drs (preferring the drr ones).

The "old" code in, say, htdp/bsl/reader.rkt, knows only the drscheme: prefix and expects drscheme:opt-out-toolbar-buttons -> #f to remove the extra buttons. If this isn't expected to work, drscheme:opt-out-toolbar-buttons should be removed entirely.

rfindler commented 3 years ago

Oh, I see. Righto!