search

racket / drracket

DrRacket, IDE for Racket
http://www.racket-lang.org/
Other
445 stars 93 forks source link

Shading for tabs doesn't invert for dark mode #494

Open Fictitious-Rotor opened 3 years ago

Fictitious-Rotor commented 3 years ago

Racket version: 8.1 OS: Windows 10

I keep getting thrown off by the visual language of the tabs. light-theme While in light theme, it's clear that the darker tab is the one selected.

dark-theme The dark theme of this image suggests that the lighter tab is the one selected, although this is not the case.

Would it be possible for the colours of the tabs to be inverted while in dark mode?

rfindler commented 3 years ago

Which operating system are you using? Is that windows?

Fictitious-Rotor commented 3 years ago

I'm using Windows 10, yes

rfindler commented 3 years ago

Under windows, we have trouble because we cannot tell if the OS is in dark mode or in light mode so things like the buttons and menus, etc. all don't change (as we can see in the screenshot). The tab control is also in that same layer that doesn't know if it is in dark mode or light mode.

Well, I guess it is possible to overcome this in some way, but that's the first problem to face!

Fictitious-Rotor commented 3 years ago

Would it be possible to draw information on how the buttons should be coloured based on the theme selected from within drracket - "Classic" vs "White on Black" etc?

rfindler commented 3 years ago

Most of the controls (buttons and menus) are drawn by the operating system. The racket/gui library just tells it where to put them and what the labels should be.

Fictitious-Rotor commented 3 years ago

Now I follow - that is a bit of a problem, yes

rfindler commented 3 years ago

After some discussion with @mflatt it looks my description is a bit simplistic but the bottom line is right; it is difficult to get this set up properly on windows. There is an attempt here.