search

racket / drracket

DrRacket, IDE for Racket
http://www.racket-lang.org/
Other
444 stars 93 forks source link

Make pressing Kill button call kill-evaluation #589

Closed sorawee closed 1 year ago

sorawee commented 1 year ago

Fixes #588

sorawee commented 1 year ago

@rfindler As you suggested, I investigated whether kill-evaluation was added after break-callback, and the answer is that I do not know. They were both added in the same commit https://github.com/racket/drracket/commit/b1ca4cec644125f01bb174a4d8d047d7d056ffa3, but it appears there might be further history than that, which I am unable to follow.

That being said, both kill-evaluation and break-callback (in the kill mode) used to simply shutdown the custodian. Clearing ports was added in https://github.com/racket/drracket/commit/fb702bd352f98456bc69dbb789008ef8697fb3ea, but this only applies to kill-evaluation and not break-callback's kill mode.

rfindler commented 1 year ago

Thank you. This looks like an oversight in https://github.com/racket/drracket/commit/fb702bd352f98456bc69dbb789008ef8697fb3ea, then!