Run Resyntax on drracket/private

[jackfirth]

This pull request runs Resyntax on all the reasonably-sized files in the drracket/private collection. It doesn't touch any of the huge files in this collection in order to make the pull request easier to review.

This is a repeat attempt of #611. I've made some improvements to Resyntax to address some of the feedback from that pull request. Additionally, this time I committed each run of Resyntax separately with a summary of changes in each commit. This isn't quite the commit-per-rule strategy outlined in https://github.com/jackfirth/resyntax/issues/188, but it's closer.

[rfindler]

Just for my own sanity: are these the uncontroversial changes from the previous pull request or is it better if I read through them all, to be safe?

[jackfirth]

It should be the uncontroversial changes, but you should read through them anyway. The fixes I made to Resyntax to stop it from generating the controversial changes should have worked but double checking is appreciated.

[rfindler]

Is it okay if I merge the changes to the files that don't have comments (ie everything except stick-figures.rkt)?

[jackfirth]

@rfindler I went ahead and fixed the issue in that file so it should all be good to merge now.

[rfindler]

Oh -- it was other parts of the file that weren't indented normally? So the resyntax changes were indented properly but the original lines weren't?

[sorawee]

The whole file is indented by two spaces (more than it should). I believe it's because it was converted from (module ...) to #lang, and whoever converted it didn't want to make a large diff, so they let the indentation stay the same.

[sorawee]

And that person appears to be @rfindler :)

https://github.com/racket/drracket/commit/527675d34314e4141b74874010e5dc2acce672a8

[rfindler]

Yes, that's exactly right, @sorawee . I find large whitespace diffs annoying when looking backwards through the history. This is, however, a tooling problem (or perhaps just a "learn how to use the existing tools, Robby" problem...).

[rfindler]

@jackfirth It looks like this no longer applies cleaning, so I'll tweak it and push it.

[rfindler]

I resolved the conflicts on my machine and pushed it as these commits:

• 6868b16b7357056f3a9c822a5c0b374b592e6a82
• 6a42336d802ca3921dc97f51f1c8c2d3e736134c
• 8916edae7508bfef27c8e09cbcae3866d2fe4b08
• 889f55c97a7cddaebf8faa8175d2bc481360c53e
• 2e5aba7750c7727ec21ab24ec2aa5652c26676fa

[rfindler]

And thanks!