racket / drracket

DrRacket, IDE for Racket
http://www.racket-lang.org/
Other
444 stars 93 forks source link

add pubment after-create-new-drracket-frame and after-create-new-tab #623

Closed Metaxal closed 11 months ago

Metaxal commented 1 year ago

New pubment methods to be used in next PRs by Quickscript.

Metaxal commented 1 year ago

Currently the queue-callback for create-new-drracket-frame is in quickscript, but I wonder whether it should be in the pubment method instead.

rfindler commented 1 year ago

I think we need documentation too.

Why is there a guard on filename for the call to after-create-new-tab?

Metaxal commented 1 year ago

Yes, docs, will do.

For filename, I wanted to call the hook only when an empty new tab is created. For loading file, I think augmenting on-file-load in editor<%> is more appropriate.

That said, the pubment method could well accept all the same arguments, and QS could do the guarding itself. Would you prefer this option?

rfindler commented 1 year ago

I don't have a strong opinion on any specific timing of the callbacks, actually, just as long as the entire set makes some sense together is all. I guess the docs will clarify it all, then!

Metaxal commented 12 months ago

As the message says, I removed the filename guard and added the docs. LMKWYT.