racket / drracket

DrRacket, IDE for Racket
http://www.racket-lang.org/
Other
444 stars 93 forks source link

DrRacket top bar is unreadable when the MacOs change theme with setting appearance auto #631

Closed westerp closed 11 months ago

westerp commented 11 months ago

What version of Racket are you using? DrRacket 8.7 [cs] MacOs Ventura 13.4.1 (Intel)

What program did you run? In MacOs settings I have appearance "Auto" and that makes the desktop going to dark theme in the evening and light theme in the morning. To reproduce just have DrRacket open when transitioning from or to dark theme.

What should have happened? When DrRacket window changes theme the font color should also change so that they are readable.

If you got an error message, please include it here.

Please include any other relevant details When I have DrRacket open when it switches theme, the DrRacket window changes the window colors, but the font color in the top bar where the "Save definitions" and "Debug" stays the same, rendering them unreadable.

sorawee commented 11 months ago

I can't reproduce the exact problem that you described on the current snapshot (https://snapshot.racket-lang.org/). Can you try it and confirm that it's already fixed? And if not, can you provide the screenshots that demonstrate the problem?

FWIW, here are mine:

At startup in the light mode:

Screenshot 2023-07-26 at 1 56 00 PM

After switching to the dark mode:

Screenshot 2023-07-26 at 1 56 11 PM

The issues are not all fixed though. For example, "DrRacket" link on the REPL pane is still incorrectly colored after the OS theme switch. The workaround is to restart DrRacket, or open a new tab.

FWIW, @rfindler stated before that this class of issues is known. It's just a matter of finding time to fix them.

westerp commented 11 months ago

I can confirm it is already fixed. Sorry about this