search

racket / drracket

DrRacket, IDE for Racket
http://www.racket-lang.org/
Other
444 stars 93 forks source link

Wrong background color for recycling symbol. #644

Closed soegaard closed 8 months ago

soegaard commented 9 months ago

This screenshot is from DrRacket 8.10 [cs] on macOS using the "Tol's White on Black" theme.

image

It shows tha the background color of the recycling symbol doesn't match the panel color.

rfindler commented 9 months ago

It's also true in black-on-white mode:

Screenshot 2023-09-24 at 8 15 51 PM

It is somewhat intentional, as this place also responds to clicks (triggering a GC).

soegaard commented 9 months ago

Ah! It's the black outline that makes it look good in light mode. Maybe add a white outline in dark mode?

rfindler commented 9 months ago

Ah, that change isn't the whole story, I guess: the gc icon doesn't react to the change to dark mode until you create a new frame. But does it look okay? Or should it be a bit less bright, perhaps?

sorawee commented 8 months ago

This is what it looks like now:

Screenshot 2023-10-07 at 10 03 53 AM

The switch from white to black or black to white still doesn't happen immediately -- it only switches when a new window is created. But I think that's a separate issue.

rfindler commented 8 months ago

I agree! Thank you.

On Fri, Oct 6, 2023 at 10:07 PM sorawee @.***> wrote:

Closed #644 https://github.com/racket/drracket/issues/644 as completed via racket/gui#309 https://github.com/racket/gui/pull/309.

— Reply to this email directly, view it on GitHub https://github.com/racket/drracket/issues/644#event-10581019457, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADBNMHKFN26CIIL3EUVX6TX6DBPDAVCNFSM6AAAAAA5E2JBJOVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJQGU4DCMBRHE2DKNY . You are receiving this because you commented.Message ID: @.***>