search

racket / gui-pkg-manager

Other
2 stars 11 forks source link

Handle closed message-box #2

Closed gus-massa closed 8 years ago

gus-massa commented 8 years ago

In DrRacket, in the window of the "Package Manager" > "Copy from version", if a push the "Remove" button and then I close the messagebox with the "x" in the top right, I get this error:

=: contract violation
  expected: number?
  given: #f
  argument position: 2nd
  other arguments...:
   1
  context...:
   C:\Program Files\Racket\share\pkgs\gui-pkg-manager-lib\
   pkg\gui\private\by-migrate.rkt:56:4:remove-package-info

I think I fixed the error and another similar use of message-box/custom.

There are also two instances of message-box but I don't understand the flow enought to be sure if they need a fix too: by-list.rkt#L280 and by-source.rkt#L309

mflatt commented 8 years ago

This change looks right to me, and the message-box uses looks ok. Thanks!