search

racket / htdp

Other
93 stars 70 forks source link

Split out test engine syntax #119

Closed mikesperber closed 3 years ago

mikesperber commented 4 years ago

This way, other languages can use the same utilities without inheriting the same concrete syntax.

Also, fixes namespace pollution that got noticed by the test-docs-complete check.

sorawee commented 4 years ago

Just in case you have not seen the error: https://github.com/racket/htdp/pull/119/checks?check_run_id=1373149910#step:6:520 indicates that this PR will break https://github.com/racket/deinprogramm/blob/master/deinprogramm/deinprogramm/DMdA/private/primitives.rkt because test-engine/racket-tests no longer provides check-expect-maker.

One possible way to avoid breaking things is that for this PR, test-engine/racket-tests should still provide check-expect-maker. Once the PR is merged, deinprogramm/DMdA/private/primitives.rkt could be modified to require check-expect-maker from test-engine/syntax. Finally, once that's done, test-engine/racket-tests could drop check-expect-maker.

mikesperber commented 3 years ago

@sorawee Thanks for the review! I'll push the fix for deinprogramm as soon as this one is in.