racket / macro-debugger

Other
8 stars 16 forks source link

Unreadable text in dark theme #35

Closed sorawee closed 3 years ago

sorawee commented 3 years ago

When running the macro stepper via raco macro-stepper, the text area has white background, causing some text to be unreadable.

Screen Shot 2021-03-11 at 12 39 47 AM
rfindler commented 3 years ago

Maybe the code needs to use text:foreground-color-mixin and canvas:color-mixin?

rmculpepper commented 3 years ago

The editor does use text:foreground-color-mixin, and the canvas is already a canvas:color%.

I haven't managed to reproduce the problem (on Ubuntu or on Mac OS). Can you check whether it still exists? If so, what platform, and what combination of configurations (OS and DrRacket) makes it happen?

sorawee commented 3 years ago

It still exists. Mac OS and DrRacket 8.0.0.13--2021-04-05(e8f857cc/d) [cs].

sorawee commented 3 years ago

Aha! I think the part that we missed earlier is that it's related to theme. Tol's White on Black (installed by default) and Spacemacs Dark (user installed) seem to trigger the issue, but White on Black (installed by default) does not.

rmculpepper commented 3 years ago

Thanks, that helped! I've pushed a fix.