search

racket / pict

Other
15 stars 20 forks source link

Removes srcloc attached to stx define-code passes to given typeset-code #47

Closed LeifAndersen closed 5 years ago

LeifAndersen commented 5 years ago

Before it would give a syntax object with line 155, which is the location of the syntax object in texpict/code. This can mess up variants of typeset-code that track the source location of the top most syntax object.

mflatt commented 5 years ago

The comment above that line certainly suggests that this is a good change. I think the comment probably dates from a time when bytecode didn't preserve source locations of syntax-object literals.

LeifAndersen commented 5 years ago

That makes sense. I don't really see any docs that I should update, so shall I go ahead and merge?

mflatt commented 5 years ago

Yes