search

racket / pict

Other
15 stars 20 forks source link

Add linestyle to tree-edge #48

Closed RenaissanceBug closed 5 years ago

RenaissanceBug commented 5 years ago

This PR adds an #:edge-style keyword to the tree-edge function, similar to the existing #:edge-width keyword.

I don't know what version number is appropriate to add for an @history footnote, so I've left a TODO comment in its place.

rfindler commented 5 years ago

This looks good to me. Re: history, this is what you want:

@history[#:changed "1.3" @list{Added the @racket[#:edge-width] option.}
         #:changed "1.9" @list{Added the @racket[#:edge-style] option.}]

I guess I was confused about how version numbers work when #:edge-width was added.

RenaissanceBug commented 5 years ago

Cool, I got to rewrite history. :)

rfindler commented 5 years ago

This looks okay to me. Does "squash and merge" actually create a merge commit or does it rebase after the squash?

samth commented 5 years ago

Squash and merge does not create a merge commit.

On Wed, Jan 30, 2019, 6:22 PM Robby Findler <notifications@github.com wrote:

This looks okay to me. Does "squash and merge" actually create a merge commit or does it rebase after the squash?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/racket/pict/pull/48#issuecomment-459150990, or mute the thread https://github.com/notifications/unsubscribe-auth/AAO78x34u8Y5H85BOwW9EQaPUpUQ1oIRks5vIilLgaJpZM4aZNbZ .

rfindler commented 5 years ago

@RenaissanceBug if you're good with this, I'll squash-and-merge.

RenaissanceBug commented 5 years ago

Fine by me!

On Jan 30, 2019, at 15:26, Robby Findler notifications@github.com wrote:

@RenaissanceBug if you're good with this, I'll squash-and-merge.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.