Unlike a VM, a docker container crashes when out of memory. I would expect the build to record a failure and move on to the next package, but currently the build crashes:
I believe the crash was due to the call to vm-stop, which calls docker-stop, which throws if the container is not running.
This PR modifies vm-stop to be a no-op if the container isn't running. I'm not sure whether this is the correct solution---we want to be sure to record a failure. At least in the specific case I ran into, the package was recorded in test-fail via a timeout failure, so the existing logic may be enough.
Unlike a VM, a docker container crashes when out of memory. I would expect the build to record a failure and move on to the next package, but currently the build crashes:
I believe the crash was due to the call to
vm-stop
, which callsdocker-stop
, which throws if the container is not running.This PR modifies
vm-stop
to be a no-op if the container isn't running. I'm not sure whether this is the correct solution---we want to be sure to record a failure. At least in the specific case I ran into, the package was recorded intest-fail
via a timeout failure, so the existing logic may be enough.