Add dependencies to Dockerfiles

racket / pkg-build

Other

5 stars 9 forks source link

Add dependencies to Dockerfiles #11

Closed michaelballantyne closed 4 years ago

michaelballantyne commented 4 years ago

pkg-build-deps-min:

sqlite seems to be needed to build documentation

pkg-build-deps:

libglib2.0-0 and libpangocairo-1.0-0 seem to be needed for racket/draw, which is used in tests and documentation
After figuring out glib, pango, and cairo, I didn't want to go through additional builds to see exactly what else is required. The packages libjpeg8 libpng12-0 libgtk2.0-0 libgdk-pixbuf2.0-0 are "suggested" by the racket package on Ubuntu 16.04, so I reasoned that they may be needed.
It its convenient to be able to check out and build Racket from source using the same image, so I include make and git.

michaelballantyne commented 4 years ago

I'm also a little confused about racket/pkg-build:pkg-build-deps-min vs mflatt/pkg-build-deps:min.

samth commented 4 years ago

I think the answer to your question is that we missed changing the "mflatt" to "racket" when creating the newer images.

mflatt commented 4 years ago

Unless I misunderstand, this isn't the intent of those Docker images. They're meant to be used with natipkg builds. The "racket-x86_64-linux-natipkg-3" Racket package provides "libsqlite.so", for example.

If you want to try non-natipkg builds, then different Docker images are appropriate — maybe ones that exist based on buildpack-deps, such as racket/unix-installer-test, or maybe ones that need to be created.

michaelballantyne commented 4 years ago

Ah, okay. How do I make my own natipkg build from modified source? I don't see anything obvious in https://github.com/racket/racket/blob/master/build.md about that.

mflatt commented 4 years ago

You'll need a site configuration written in distro-build/config that includes #:configure '("--enable-natipkg").

michaelballantyne commented 4 years ago

Thanks, I'll give that a try.