racket / plot

Other
40 stars 37 forks source link

fix the types fo LVof #99

Closed capfredf closed 3 years ago

capfredf commented 3 years ago

change those types to be forward-compatible with TR's upcoming changes where polymorphic types are not replacements of type constructors any more.

capfredf commented 3 years ago

related to https://github.com/racket/typed-racket/pull/1143

alex-hhh commented 3 years ago

This looks good to me. @samth , is this change OK to merge? If it is I will merge it and also put it on the release branch to make it into 8.3.

capfredf commented 3 years ago

@alex-hhh it should be fine. The change I made is compatible with all past and current version of Typed Racket where define-type is supported. And we won't make the linked change set to Type Racket into 8.3. After all, it is still a work-in-progress.

alex-hhh commented 3 years ago

OK, I merged it down, but will not add this change to the release branch so it won't be in 8.3