search

racket / racket-pkg-website

A frontend for the Racket Package Catalog.
Other
9 stars 15 forks source link

undefined in "Create a new package" #63

Closed sorawee closed 6 years ago

sorawee commented 6 years ago

A picture is worth a thousand words

screenshot from 2018-03-08 18-58-46

greghendershott commented 6 years ago

Sorry for the drive-by back-seat commentary but I happened to notice this and get curious how the site worked. From what I could figure out:

It looks like commit 180e0c9a "Remove support for unencrypted git transports. (git:// and http://)" by @technomancy maybe also needed to update static/editpackage.js?

It seems like a quick, safe hack could be to replace pieces[1] with a hardcoded 'https' here?

(A more-thorough cleanup would be to remove that element form pieces, shift all the other indexes -- and try not to make a new bug.)

jeapostrophe commented 6 years ago

Thanks for the report and thanks for the pointer Greg. I'm going with the safe thing for now.