search

racket / rackunit

Other
18 stars 34 forks source link

typed: Remove extra call to `current-test-case-around` #133

Closed jessealama closed 2 years ago

jessealama commented 3 years ago

It's not necessary to wrap a test case in current-test-case-around; that will be done later. Doing so increments the running test count (and, possibly, the running test failure count) twice.

The proposed change may seem implausible on its face. I also feel somewhat less than confident that this is the right thing to do. But I can confirm that this does the job.

closes #132

jackfirth commented 3 years ago

I think the problem isn't that this macro expands to a use of current-test-case-around, I think it's that it tries to expand to current-test-case-around and also do the test result logging at the same time. Instead of removing the current-test-case-around usage, I think we should update this code to use roughly the same implementation strategy that the untyped macros use.