search

racket / rackunit

Other
18 stars 32 forks source link

Support images in check failure output #140

Closed aymanosman closed 3 years ago

aymanosman commented 3 years ago

Fixes #130

This PR makes rackunit print values directly, as opposed to turning them into strings first.

rmculpepper commented 3 years ago

When I try running the following program in DrRacket, I still get the picts printed as #<pict> in the output. Is it working for you?

#lang racket/base
(require pict rackunit)
(check-equal? (circle 10) (circle 20))
aymanosman commented 3 years ago

You are right, thanks. I broke the implementation whilst fixing a merge conflict. Should be fixed now.

samth commented 3 years ago

I think this merge broke the previous merge -- see the tests now failing at: http://drdr.racket-lang.org/57762/cs/racket/share/pkgs/rackunit-test/tests/rackunit/standalone.rkt and http://drdr.racket-lang.org/57762/cs/racket/share/pkgs/rackunit-test/tests/rackunit/run-tests.rkt

samth commented 3 years ago

This change broke the rackunit-fancy-runner ~rackunit-pretty-runner~ package, which was using the private info-value->string function. Would it make sense to restore that function using the new code written in this PR?

aymanosman commented 3 years ago

@samth Can't seem to find that package anywhere.

samth commented 3 years ago

@aymanosman it's here: https://pkgs.racket-lang.org/package/rackunit-fancy-runner

samth commented 3 years ago

I see that you couldn't find it because I wrote the wrong name, sorry about that!