search

racket / rackunit

Other
18 stars 32 forks source link

Revert "Fix tr srcloc" #154

Closed capfredf closed 2 years ago

capfredf commented 2 years ago

Reverts racket/rackunit#153

capfredf commented 2 years ago

@samth can you merge this PR?

samth commented 2 years ago

Is there breakage that we need to fix caused here?

capfredf commented 2 years ago

I just feel the pr that got merged was not thoroughly reviewed, and issues raised by @jackfirth and @bennn in your original PR have not been addressed.

jbclements commented 2 years ago

I got the sense that Sam was interested in seeing whether the patch caused any breakage.

Again, my apologies for getting you into this.

capfredf commented 2 years ago

No worries. @jbclements

bennn commented 2 years ago

I had only typo-level comments for the original PR, so I went ahead & pushed fixes for those to master (edit: sorry for the conflicts) https://github.com/racket/rackunit/commit/83224ac1ac1958e6f0a01dab15648ecee8c68869