add empty rackunit-typed package for earlier racket versions

[AlexKnauth]

When earlier racket installations (6.10 and below) look for the rackunit-typed package, they currently find the main non-empty rackunit-typed package in the catalog. This creates a conflict with typed-racket-more, with them both trying to provide different versions of typed/rackunit. This pull request adds a dummy rackunit-typed package that earlier racket versions can point to.

The catalog entry for rackunit-typed should also have version exceptions for versions 6.10 and below pointing to the package source:

git://github.com/racket/rackunit?path=rackunit-typed#for-v-up-to-6.10

[samth]

Looks good to me.

On Mar 11, 2018 11:13 AM, "Alex Knauth" notifications@github.com wrote:

When earlier racket installations (6.10 and below) look for the rackunit-typed package, they currently find the main non-empty rackunit-typed package in the catalog. This creates a conflict with typed-racket-more, with them both trying to provide different versions of typed/rackunit. This pull request adds a dummy rackunit-typed package that earlier racket versions can point to.

The catalog entry for rackunit-typed should also have version exceptions for versions 6.10 and below pointing to the package source:

git://github.com/racket/rackunit?path=rackunit-typed#for-v-up-to-6.10

---

You can view, comment on, or merge this pull request online at:

https://github.com/racket/rackunit/pull/93 Commit Summary

• add empty rackunit-typed package for earlier racket versions

File Changes

• A rackunit-typed/info.rkt https://github.com/racket/rackunit/pull/93/files#diff-0 (7)

Patch Links:

• https://github.com/racket/rackunit/pull/93.patch
• https://github.com/racket/rackunit/pull/93.diff

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/racket/rackunit/pull/93, or mute the thread https://github.com/notifications/unsubscribe-auth/AAO782K6JTEYNeUWGvpzxSf782QfyFQrks5tdT8NgaJpZM4Sluf0 .

[AlexKnauth]

Can you add the version exceptions?

[AlexKnauth]

@jackfirth You were the one to add the rackunit-typed package. Are you the only one who can add the version exceptions?

[AlexKnauth]

Who can add version exceptions to the rackunit-typed catalog entry?

The catalog says the only author is @jackfirth, but if he doesn't have time or can't for some other reason, who else can?

[jackfirth]

Thank you for your patience @AlexKnauth. Life's gotten away from me lately.

1. I've added samth@racket-lang.org as an author of the rackunit-typed package. Is that alright with you @samth, and is that the right email address?
2. Not sure what's up with Travis CI, but I don't think there's anything wrong with the PR so I'll merge.
3. I'll add the version exceptions up to 6.0 after merging. Should I add fewer? Or add more by including the 5.9.x versions?

[jackfirth]

Looks like the Travis failure was because the package info is missing some definitions required by the catalog metadata test

Finding packages
 Cataloging package rackunit-lib
 Cataloging package schemeunit
 Cataloging package rackunit-doc
 Cataloging package rackunit-test
 Cataloging package rackunit-typed
 Cataloging package rackunit
 Cataloging package rackunit-plugin-lib
 Cataloging package rackunit-gui
 Cataloging package testing-util-lib
Missing package description for rackunit-typed
Missing package authors for rackunit-typed

@AlexKnauth Could you open another PR that adds the pkg-desc and pkg-authors info definitions?

[AlexKnauth]

I don't see those in Package Metadata in the docs. What are the values supposed to be?

[AlexKnauth]

I've added a pull request for that here: https://github.com/racket/rackunit/pull/96

However, I don't really understand what pkg-desc and pkg-authors mean or why they are needed. Are these values correct?

(define pkg-desc "Typed Racket types for RackUnit")

(define pkg-authors '(samth stamourv))

[AlexKnauth]

There's a typo in the version exception for 6.9 in the catalog entry. It refers to the (non-existent) rackunit-type dir where it should say rackunit-typed.

[samth]

This is now fixed.

[AlexKnauth]

Thanks.