racket / rhombus

Rhombus programming language
Other
333 stars 59 forks source link

use internal-definition contexts for `let` scopes #471

Closed usaoc closed 7 months ago

usaoc commented 7 months ago

(Is this a reasonable solution?)

This allows the scope-pruning behavior of quote-syntax to apply.

Fix #467.

mflatt commented 7 months ago

This works as far as I can tell. I think we probably want to add a syntax-local-make-definition-context-introducer, or something like that, to create just one scope without the definition-context overhead, but this patch's approach would be the backward-compatible implementation.

usaoc commented 7 months ago

I’ll merge this first, and use that under a version guard later when it’s added.