search

racket / scribble

Other
201 stars 91 forks source link

margin notes can collide with each other #120

Closed SuzanneSoy closed 6 years ago

SuzanneSoy commented 7 years ago

When two margin notes are defined close to each other, they can overlap in the HTML version (in the example below, Hello and world are typeset above one another).

#lang scribble/manual
@(require scriblib/footnote)
Foo@note{Hello} bar@note{world}.

On chromium, I can fix this by changing in https://github.com/racket/scribble/blob/master/scribble-lib/scriblib/footnote.css

.NoteBox {
  …
  height: 0em;
  …
}

to

.NoteBox {
  …
  height: auto;
  clear: right;
  …
}

Is there any particular reason for having this height: 0em in the first place (e.g. compatibility with an older/another browser)?

If this change seems correct, I can submit a PR.

cwebber commented 6 years ago

I encountered this bug myself today. A PR would be most welcome!