search

racket / scribble

Other
197 stars 91 forks source link

acmart fixes #140

Closed mflatt closed 6 years ago

mflatt commented 7 years ago

The first commit makes the acmart style file disable the default Scribble redefinition of \rmdefault, since that plays badly with acmart. I'm pretty sure @LeifAndersen had the same problem, but I don't know how she fixed it.

The second one make grantsponsor and grantnum work. I think the old versions may have been a cut-and-paste error that kept too much from a related function.

The third commit is in the same vein, but for some other functions and more a question of generalizing contracts than making things work at all.

mflatt commented 6 years ago

@LeifAndersen Ok with you if I merge this along with an "acmart.cls" upgrade?

LeifAndersen commented 6 years ago

Looking more closely, but this looks pretty good to me.

Honestly, I never found a good fix. Since we were down to the wire, I just manually removed the line from the generated tex file. So having an automated fix is great to me.

LeifAndersen commented 6 years ago

Basically, I'm saying:

LGTM

mflatt commented 6 years ago

Thanks!