racket / scribble

Other
201 stars 93 forks source link

defthing: use #:id expression instead of 'id' #161

Closed bennn closed 6 years ago

bennn commented 6 years ago

Change implementation of defthing so that if the user gives an id-expr via the #:id keyword, then defthing never uses the default id.

I think this is right, based on the docs. But maybe the docs should change.

cc @dedbox for reporting this


Example program:

#lang scribble/manual

@defthing[#:id (datum->syntax #f 'foo) dont-use integer?]{
  Something
}

Before this PR: screen shot 2018-02-04 at 16 50 08

After this PR: screen shot 2018-02-04 at 16 50 18

bennn commented 6 years ago

e2ea830361138212974c3637e9e928bc1f753bde