search

racket / scribble

Other
197 stars 91 forks source link

Fix case sensitivity issues in bibtex #264

Closed wilbowma closed 4 years ago

wilbowma commented 4 years ago

bibtex is supposed to treat keys and labels as case insensitive, according to what I can find (http://maverick.inria.fr/~Xavier.Decoret/resources/xdkbibtex/bibtex_summary.html#stringdef). This was mostly true already, but labels and entry keys were not treated this way. This patch fixes it.

wilbowma commented 4 years ago

Closes #261

mflatt commented 4 years ago

I'm happy to merge this, but checking on one detail first: Using string-foldcase is normally more correct than string-downcase for setting up a case-insensitive comparison. It doesn't matter for English/Latin/ASCII letters, and really you want to do the same as bibtex, which may well be downcase. Do you want to keep downcase or change to foldcase?

wilbowma commented 4 years ago

Should probably use string-foldcase. I was following the existing patterns in the file, which uses string-downcase; I didn't realize I ought to use string-foldcase. However, this means the other uses should probably be changed.

mflatt commented 4 years ago

Merged (but out of GitHub to deal with conflicts).