Wishlist for HTML/JS improvement

sorawee commented 3 years ago

[ ] Use type="search" for the search box, which is semantically more correct and give us the "clear" button automatically in many browsers
[x] Refactor the use of keyCode, which is deprecated.
[ ] Refactor the use of non-standard HTML attributes. This might not be always possible because some non-standard attributes are documented publicly (e.g., x-source-module).
[x] Instead of parsing the query string ourselves, use new URL(location.href).searchParams.get(...).
[ ] == / != is evil. Use === / !== everywhere.
[ ] Avoid unsafe innerHTML set. E.g., https://docs.racket-lang.org/reference/index.html?ctxtname=%3Cdiv%20style=%22color:%20red%22%3Efoo%3C/div%3E
[ ] Replace deprecated tags with appropriate tags where applicable

Metaxal commented 1 year ago

More wishlist:

[x] Pressing / anywhere focuses the search box in the side panel. This behaviour is implemented by many websites, such as Github, Discourse, Google search, ... One example implementation here: https://github.com/pypi/warehouse/pull/10395/files

sorawee commented 10 months ago

@Metaxal that is already implemented, but under the keybinding s (for search I suppose).

Metaxal commented 10 months ago

Ooohhh, neat, thanks! :-D

On Fri, Nov 10, 2023 at 1:44 AM sorawee @.***> wrote:

@Metaxal https://github.com/Metaxal that is already implemented, but under the keybinding s (for search I suppose).

— Reply to this email directly, view it on GitHub https://github.com/racket/scribble/issues/276#issuecomment-1804945040, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMU2HD4TCWKVPXHOUGKZJ3YDWBGPAVCNFSM4R5DJ2LKU5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCOBQGQ4TINJQGQYA . You are receiving this because you were mentioned.Message ID: @.***>

racket / scribble

Wishlist for HTML/JS improvement #276