search

racket / scribble

Other
201 stars 92 forks source link

Fix JS error when searchbox is not present #277

Closed sorawee closed 3 years ago

sorawee commented 4 years ago

When the search box is not present (e.g., https://docs.racket-lang.org/demo-m1/index.html), pressing "S" will result in a JS error. This PR fixes the problem. Note that semantically it makes more sense to give an ID to the search box as we know exactly what search box we want.

mflatt commented 3 years ago

@sorawee Looks like I created a conflict by merging another PR. It's probably very easy to fix, but can you do that, so I can squash-merge normally?

sorawee commented 3 years ago

Yes, I will do that by the end of today.

sorawee commented 3 years ago

@mflatt conflict resolved. Sorry for the delay.