racket / scribble

Other
197 stars 90 forks source link

Migrate from let forms to definitions #294

Closed jackfirth closed 3 years ago

jackfirth commented 3 years ago

This pull request was generated by the automated refactoring tool resyntax. It replaces uses of let forms with define forms, when doing so would decrease nesting and wouldn't change the existing binding structure. Some replacements were not made because resyntax isn't always able to preserve comments in the original code.

This is a larger-scale version of #289. While that pull request touched a single file, this one attempts to clean up the entire repository. I can split it into smaller, easier-to-review chunks if preferred. Each file's changes are independent and can be reverted independently, so it should hopefully be easy to undo any mistakes here.

jackfirth commented 3 years ago

Closing this for now because of jackfirth/resyntax#58. Will generate a new pull request after tweaking resyntax a bit.