search

racket / scribble

Other
197 stars 90 forks source link

table of contents toggle breaks layout on at least some browsers #318

Closed rfindler closed 2 years ago

rfindler commented 2 years ago

This commit causes the layout of the "top prev up next" section of the documentation to be garbled for me (on Safari on a mac, with a full-width browser). It looks okay in firefox (same window size, same os), tho.

Here's what I see:

Screen Shot 2021-10-06 at 9 44 24 AM

and here's what it looks like when I revert the commit, rebuild, and reload the page:

Screen Shot 2021-10-06 at 10 18 56 AM
sorawee commented 2 years ago

Ping @jryans in case you know what's going on.

jryans commented 2 years ago

Ah, thanks for the ping, I'll take a look!

jryans commented 2 years ago

I can indeed reproduce the issue here, and it seems to only affect desktop Safari somehow. Anyway, I'll work on a fix.

sorawee commented 2 years ago

Did this PR make to 8.3? docs.racket-lang.org currently looks like this on Firefox.

Screen Shot 2021-11-08 at 3 28 39 AM

Note that I don't notice this problem in my raco docs -- and my Racket is currently at git HEAD.

jryans commented 2 years ago

@sorawee Yes, the above markup change has been included correctly in the deployed markup for 8.3.

I believe the visual issue you're seeing is related to a short-lived caching bug with the deployment, as this morning I noticed that the CSS and JS files on docs.racket-lang.org didn't appear to be updated, but when I added a random query string (e.g. ?123), the newer version came through. After a few hours, the updated files eventually came through as part of a regular page load.

On my side, things are now looking correct here.

image image

If you're still seeing issues after a few hours, I think it would be good to open a new issue to track this.

sorawee commented 2 years ago

Yes, it renders correctly now! :)