search

racket / scribble

Other
194 stars 90 forks source link

Analyze pull requests with Resyntax #336

Closed jackfirth closed 1 year ago

jackfirth commented 2 years ago

This is a similar pull request to racket/typed-racket#1250. @mflatt suggested the Scribble repository as another good project to try Resyntax on, since it's old, large, and frequently receives pull requests. See the typed racket pull request for details about what this change does. TL;DR: it runs Resyntax over pull requests and leaves github reviews with suggested improvements.

mflatt commented 2 years ago

Are the CI failures for the PR something to be fixed, first? I'm not really clear on how this is supposed to work.

jackfirth commented 2 years ago

Yeah, this shouldn't be merged until it's passing. I'll mark it as a draft PR for now to make that clearer, and I'll investigate the failures when I get some time for it.

jackfirth commented 1 year ago

Closing this in favor of #350.