racket / scribble

Other
194 stars 90 forks source link

tex-table: add guillemetleft and guillemetright #367

Closed AlexKnauth closed 1 year ago

AlexKnauth commented 1 year ago

guillemetleft for «, and guillemetright for ».

See also https://github.com/racket/gui/pull/297

rfindler commented 1 year ago

@AlexKnauth it looks like these changes broke the redex documentation. It looks to me like there needs to be some delimiteres somewhere. In the generated latex for the redex docs I see:

\begin{SCodeFlow}\begin{RktBlk}\begin{SingleColumn}\RktPn{(}\RktSym{\badlink{\RktValLink{collection{-}file{-}path}}}\mbox{\hphantom{\Scribtexttt{x}}}\textbf{\guillemotleftfilename.rkt\guillemotright}

\mbox{\hphantom{\Scribtexttt{xxxxxxxxxxxxxxxxxxxxxx}}}\RktVal{"redex"}

\mbox{\hphantom{\Scribtexttt{xxxxxxxxxxxxxxxxxxxxxx}}}\RktVal{"examples"}

\mbox{\hphantom{\Scribtexttt{xxxxxxxxxxxxxxxxxxxxxx}}}\RktVal{"define{-}judgment{-}form"}\RktPn{)}\end{SingleColumn}\end{RktBlk}\end{SCodeFlow}

\noindent replacing \textbf{\guillemotleftfilename.rkt\guillemotright} with one of the names listed above.

which looks like it has "filename.rkt" right up against \guillemotleft but there should probably be a {} between them.

Looking at the diff here, I think that probably just adding {} to the end of the strings should work. I'll give that a try.

AlexKnauth commented 1 year ago

Would a similar thing need to be done for vdots and hdots above that?

rfindler commented 1 year ago

Would a similar thing need to be done for vdots and hdots above that?

Sounds worth trying to sort out. Maybe the way it happened in the redex docs with guillemets is good place to start when trying to figure that out.

AlexKnauth commented 1 year ago

So I found a similar problem with vdots. But not with hdots because the hdots case is dead code, subsumed by the cdots case.