search

racket / scribble

Other
199 stars 91 forks source link

refactor: modernize JS in scribble-common.js #379

Closed sorawee closed 11 months ago

sorawee commented 11 months ago

Browsers released within the last 5 years (the partial support tier according to https://github.com/racket/scribble/pull/240) support URLSearchParams, so we should use it.

sorawee commented 11 months ago

As a side effect, this handles query string much better than what it currently does. For example, the malformed query string in https://github.com/racket/scribble/pull/329 / https://github.com/greghendershott/racket-mode/issues/623 can now be decoded with no issue.

sorawee commented 11 months ago

Thank you for the feedback, @yfzhe!