search

racket / scribble

Other
199 stars 91 forks source link

Refactor racket.rkt #400

Closed sorawee closed 9 months ago

sorawee commented 9 months ago

This PR consists of two parts: semi-automatic fixes by Resyntax, and manual fixes.

Resyntax fixes

Resyntax fixes are commits with the prefix resyntax:. Each commit corresponds to fixes due to a rule. The methodology to produce fixes is as follows:

  1. Run Resyntax, and pick "the first fix".
  2. Apply all fixes with the same rule as "the first fix".
  3. Re-run Resyntax again to possibly get more fixes, and go to step 3 until we reach the fixed point.

Resyntax is modified to omit some rules that are not suitable for the file, but it is also made more lenient in presence of comments (https://github.com/jackfirth/resyntax/issues/232), making it possible to discover fixes that the standard Resyntax can't discover.

sorawee commented 9 months ago

I have more changes to make, but this is a large enough PR already, so I'd rather stop here for now.

mflatt commented 9 months ago

LGTM, but if it's not pressing, just after the v8.12 branch? (Not that problems seem likely, but just in case.)

sorawee commented 9 months ago

Definitely not pressing!

samth commented 9 months ago

Let's merge this now so we don't forget.