racketscript / racketscript-playground

Online playground from RacketScript
MIT License
19 stars 9 forks source link

GitHub saving #25

Closed stchang closed 3 years ago

stchang commented 3 years ago

Needs a local .env file for the app secrets. Not sure how to add that to docker deploy, since it's not checked in?

stchang commented 3 years ago

needs https://github.com/vishesh/racketscript/pull/225

vishesh commented 3 years ago

When running Docker we can pass --env-file parameter. We'd have to manually copy the file though. I can write a quick script to automate the process of copying env file and starting the new build. We can keep all that in a private repo in racketscript org.

stchang commented 3 years ago

ok nice. .env file needs to have:

PLAYGROUND_GITHUB_CLIENT_ID="client id from gh oauth app"
PLAYGROUND_GITHUB_SECRET="client secret from gh oauth app"

I created an app in the racketscript org so we can use those credentials for the deployed app. Though gh complained when I tried to check it in, maybe private repo is ok though.

stchang commented 3 years ago

fixes #5

stchang commented 3 years ago

requires https://github.com/vishesh/racketscript/pull/235

stchang commented 3 years ago

This is ready for merge. I'll create a separate private repo for the .env file

stchang commented 3 years ago

Next time you can squash all my annoying commits :)