search

racklet / electronics-prototyping

Design files for electronic components for use in Racklet
Apache License 2.0
3 stars 0 forks source link

Switch over to our `kicad_parse_gen` branch with fixed escaping #22

Closed twelho closed 3 years ago

twelho commented 3 years ago

PR against upstream: https://github.com/productize/kicad-parse-gen/pull/9. The last commit to upstream was in 2019, so the project seems to be a bit dormant right now. Thus, I propose switching over to our own fork where I've fixed the escaping (in kicad5-escape-fix) for now. This eliminates the need for the escape and unescape workarounds, as escaped characters are now correctly handled in the function responsible for input parsing in the library.

cc @luxas @chiplet

chiplet commented 3 years ago

We might even want to merge the kicad5-escape-fix branch first and default to using the main branch of our fork as the dependency.

twelho commented 3 years ago

We might even want to merge the kicad5-escape-fix branch first and default to using the main branch of our fork as the dependency.

Yep that might be a good idea, I've now merged kicad5-escape-fix to master in our fork and updated this PR accordingly. Will merge now.