search

rackspace-cookbooks / elkstack

Elasticsearch, logstash, and kibana stack
Other
81 stars 54 forks source link

normal vs default attribute #171

Closed phoolish closed 8 years ago

phoolish commented 8 years ago

Why is a normal attribute used vs a default attribute on https://github.com/rackspace-cookbooks/elkstack/blob/master/attributes/logstash.rb#L2 ? Is this due to an upstream cookbook?

martinb3 commented 8 years ago

Yes, at the time it was due to the upstream cookbook.

martinb3 commented 8 years ago

There's some major releases pending in elasticsearch (the cookbook) tied to v2.0.0 of Elasticsearch (the software project), but then I'd like to do a big refactor of elkstack to catch it up to the new versions.

phoolish commented 8 years ago

That sounds great. I'd be interested in assisting (especially with the logstash integration) as we use this cookbook pretty extensively in our setup.

martinb3 commented 8 years ago

@phoolish That would be wonderful! Honestly, we could start any time.

martinb3 commented 8 years ago

I think we're looking at: https://github.com/elastic/cookbook-elasticsearch/tree/2.0.0_wip (will be merged to master) https://github.com/lusis/chef-logstash (master as of now) https://github.com/lusis/chef-kibana (master as of now)

So I'm thinking we'd bump to those, and then refactor.

phoolish commented 8 years ago

That makes sense. Could you also elaborate on #136?

martinb3 commented 8 years ago

@phoolish I tried to update that. At it's core, it's basically "refactor" so we are doing the interesting work around E, L, and K but not necessarily write custom implementations of things like SSL certificates.

phoolish commented 8 years ago

Seems like the right approach. I'll get started tomorrow.