Neutron Security Groups should support IP Protocol Numbers

rackspace / gophercloud

A Go SDK for OpenStack. IN FEATURE FREEZE. See Issue #592

http://gophercloud.io

Other

456 stars 180 forks source link

Neutron Security Groups should support IP Protocol Numbers #544

Open toddnni opened 8 years ago

toddnni commented 8 years ago

I took a look into the Neutron security rule code and it seems that one cannot define protocol using IP Protocol Numbers (see the code in openstack/networking/v2/extensions/security/rules).

Compare this to Neutron code https://github.com/openstack/neutron/blob/master/neutron/extensions/securitygroup.py#L142 that checks if input is in range 0-255.

Ability to input a number is required if for example one wants to enable IGMP and VRRP protocols for keepalived.

jrperritt commented 8 years ago

Ah, true. We just need to pass in a CreateOptsBuilder interface like everywhere else in the library and then have CreateOpts implement it.