[rfr] Adding LBaaS v2 Support

[dagnello]

This PR includes LBaaS V2 Support for the following components (ref. #460):

• Loadbalancers
• Listeners
• Pools and Members
• Health Monitors

LbaaS v2 API documentation: http://developer.openstack.org/api-ref-networking-v2-ext.html Note: There are some details missing/invalid in current docs, I have been using client calls with --debug flag to see what the API actually returns.

[coveralls]

Coverage increased (+0.4%) to 80.924% when pulling 6150ff000d7594d977f76974d564e084ba3f2fe9 on hpcloud:lbaas-v2 into adc206589ed49d18cecc9890ab93534704b04702 on rackspace:master.

[coveralls]

Coverage increased (+0.4%) to 80.97% when pulling 5cf21d186233db17fd932f91affcd15338c190a0 on hpcloud:lbaas-v2 into adc206589ed49d18cecc9890ab93534704b04702 on rackspace:master.

[coveralls]

Coverage increased (+0.4%) to 80.97% when pulling 7fc1647ee4788e4a70f01d7f7c43b0ba68410bc0 on hpcloud:lbaas-v2 into adc206589ed49d18cecc9890ab93534704b04702 on rackspace:master.

[coveralls]

Coverage increased (+0.4%) to 80.97% when pulling 1e5634193f1265442d854cf3e9f0a4207228ea80 on hpcloud:lbaas-v2 into adc206589ed49d18cecc9890ab93534704b04702 on rackspace:master.

[coveralls]

Coverage increased (+0.4%) to 80.97% when pulling 67effefb6c0d51461a2be86cbb2e6b14bfe27cb2 on hpcloud:lbaas-v2 into adc206589ed49d18cecc9890ab93534704b04702 on rackspace:master.

[coveralls]

Coverage increased (+0.4%) to 80.97% when pulling 8ff5e0e2d134beaa06c0d9466fb9721fda8773b2 on hpcloud:lbaas-v2 into adc206589ed49d18cecc9890ab93534704b04702 on rackspace:master.

[dagnello]

hi @jrperritt, this PR is ready for review.

[jamiehannaford]

Thanks for the great work @dagnello. I've left some feedback.

[dagnello]

@jamiehannaford Thank you for the feedback!

[jrperritt]

@dagnello To aid in reviewing this, can you post (either in this PR or the issue) links to the files in the source code you're using to define these APIs?

[dagnello]

@jrperritt, API doc link added to this PR.

[jrperritt]

@dagnello right, we'll want links to the API (preferably schema if one exists) in the actual source code since, as you noted, the docs and source often don't align.

[dagnello]

@jrperritt ok, add the link in the doc.go for the lbaas_v2 package?

[jrperritt]

Yeah, that would fine. Just the link(s) where someone can look and see that, say, a certain field exists and is the correct type.

[dagnello]

got it, thanks

[coveralls]

Coverage increased (+0.3%) to 80.836% when pulling 5e35bf5e2110e29300f418167f3e2087a9186718 on hpcloud:lbaas-v2 into adc206589ed49d18cecc9890ab93534704b04702 on rackspace:master.

[dagnello]

@jamiehannaford I have addressed your feedback, PR has been updated.

[coveralls]

Coverage increased (+0.4%) to 80.929% when pulling 4a558933d3683b913aa643ca13f81d1dc9ffa9a4 on hpcloud:lbaas-v2 into adc206589ed49d18cecc9890ab93534704b04702 on rackspace:master.

[coveralls]

Coverage increased (+0.4%) to 80.929% when pulling 3b46a2ec3430c5edb2dcb0414a5221ac94e56d6b on hpcloud:lbaas-v2 into adc206589ed49d18cecc9890ab93534704b04702 on rackspace:master.

[coveralls]

Coverage increased (+0.4%) to 80.929% when pulling 6503b2bab64912ea4068ebc24243c1e3851a1c3a on hpcloud:lbaas-v2 into adc206589ed49d18cecc9890ab93534704b04702 on rackspace:master.

[coveralls]

Coverage increased (+0.4%) to 80.929% when pulling c16895b315a6759ea9d51a4c89690bd5ed679d37 on hpcloud:lbaas-v2 into adc206589ed49d18cecc9890ab93534704b04702 on rackspace:master.

[coveralls]

Coverage increased (+0.4%) to 80.927% when pulling e45cfc41263cc2f9448ad6caa3e4e0b896b4fe9b on hpcloud:lbaas-v2 into adc206589ed49d18cecc9890ab93534704b04702 on rackspace:master.

[dagnello]

@jrperritt @jamiehannaford ready for review

[dagnello]

@jamiehannaford @jrperritt this PR is ready for additional review.

[dagnello]

@anguslees can you also review this PR

[coveralls]

Coverage increased (+0.6%) to 81.141% when pulling 5ec078bf9c18ee7591191c61a82218eb0541b71e on hpcloud:lbaas-v2 into ff42b6ac0094d26632d2bac96b7dea0f1b7e98bb on rackspace:master.

[coveralls]

Coverage increased (+0.6%) to 81.141% when pulling 0038ed8493cae9694d19bdce50715d7877be0ebc on hpcloud:lbaas-v2 into ff42b6ac0094d26632d2bac96b7dea0f1b7e98bb on rackspace:master.

[anguslees]

lgtm from a purely golang pov. I haven't compared against actual LBaaS API at all.

[dagnello]

@anguslees thank you for the review

[coveralls]

Coverage increased (+0.5%) to 81.069% when pulling 83913142f2bf6e5ac040fe829430509d01d68300 on hpcloud:lbaas-v2 into 6fbd243473c9984e40119ce8b96be8bfd1cb75d8 on rackspace:master.

[coveralls]

Coverage increased (+0.5%) to 81.069% when pulling b4261c8afd0c82e6a2e567e849759141c382d30d on hpcloud:lbaas-v2 into 6fbd243473c9984e40119ce8b96be8bfd1cb75d8 on rackspace:master.

[coveralls]

Coverage increased (+0.6%) to 81.158% when pulling 2eca5b195f960b4994755231c15af3801df3b90b on hpcloud:lbaas-v2 into 6fbd243473c9984e40119ce8b96be8bfd1cb75d8 on rackspace:master.

[dagnello]

@jamiehannaford @jrperritt I have addressed all comments, please review and merge if ready.

[vipulsabhaya]

@jrperritt do we look good for a merge? This is now blocking some Kubernetes and Terraform work.

[jrperritt]

do we look good for a merge?

Definitely not. At the least there's this: https://github.com/rackspace/gophercloud/pull/575#discussion_r64760778 . Then someone (probably me) will need to review it thoroughly by going through the OpenStack source code to validate the API.

This is now blocking some Kubernetes and Terraform work.

The considerations for merging this PR (and indeed all PRs) are its correctness and consistency with the rest of the library. Larger PRs often take more time to go through the review process

[coveralls]

Coverage increased (+0.3%) to 80.886% when pulling eab574f4c766870334c0cbd387af391063c23209 on hpcloud:lbaas-v2 into 6fbd243473c9984e40119ce8b96be8bfd1cb75d8 on rackspace:master.

[coveralls]

Coverage increased (+0.3%) to 80.887% when pulling 645a55c7f8407e553110ea39b09a5221c55a308d on hpcloud:lbaas-v2 into 6fbd243473c9984e40119ce8b96be8bfd1cb75d8 on rackspace:master.

[coveralls]

Coverage increased (+0.3%) to 80.887% when pulling ec934452b32ef270af6de5f0c9bd8472a43c2f30 on hpcloud:lbaas-v2 into 6fbd243473c9984e40119ce8b96be8bfd1cb75d8 on rackspace:master.

[coveralls]

Coverage increased (+0.3%) to 80.887% when pulling e230bbfdce2f4f73d8d321a700a007c3f8cd54fd on hpcloud:lbaas-v2 into 6fbd243473c9984e40119ce8b96be8bfd1cb75d8 on rackspace:master.

[dagnello]

@jamiehannaford @jrperritt the remaining comments have been addressed.

[coveralls]

Coverage increased (+0.3%) to 80.887% when pulling bb39de2a7b2e51e271cb33d889250392b938a30c on hpcloud:lbaas-v2 into 6fbd243473c9984e40119ce8b96be8bfd1cb75d8 on rackspace:master.

[vipulsabhaya]

@jrperritt Please review, and let us know of any outstanding issues.

[jamiehannaford]

All tests pass, merging. Thanks for the great work @dagnello 🚀

[dagnello]

@jamiehannaford thank you!