Fix selection of v2 volumes in openstack blockstorage

rackspace / gophercloud

A Go SDK for OpenStack. IN FEATURE FREEZE. See Issue #592

http://gophercloud.io

Other

456 stars 181 forks source link

Fix selection of v2 volumes in openstack blockstorage #579

Closed ncw closed 8 years ago

ncw commented 8 years ago

After reviewing #489 I think this is a better way of selecting v2 volumes. It certainly works in my testing.

This was committed originally in da546143

@feiskyer since you wrote the original code do you agree?

I'm unable to find the definitive openstack document which states valid values for the type field in the catalog though!

coveralls commented 8 years ago

Coverage increased (+0.04%) to 80.586% when pulling b64fd201c79e030b4784b307460c5a988843e1e6 on ncw:fix-volume-selection into adc206589ed49d18cecc9890ab93534704b04702 on rackspace:master.

jrperritt commented 8 years ago

At the least, the sample catalog here has the proposed fix as the type. +2