fixing build constraints for lbaas_v2 fixtures

rackspace / gophercloud

A Go SDK for OpenStack. IN FEATURE FREEZE. See Issue #592

http://gophercloud.io

Other

456 stars 181 forks source link

fixing build constraints for lbaas_v2 fixtures #591

Closed sputnik13 closed 8 years ago

sputnik13 commented 8 years ago

Build constraints are missing a line after the build constraint as required by https://golang.org/pkg/go/build/, and the fixtures are being pulled in by standard builds, causing test code to be included in the final binary.

sputnik13 commented 8 years ago

@jrperritt @jamiehannaford this is related to https://github.com/rackspace/gophercloud/pull/575

we really need this fix in order to merge https://github.com/kubernetes/kubernetes/pull/25987

Your help is much appreciated, thank you

coveralls commented 8 years ago

Coverage remained the same at 80.887% when pulling 8b6b1b7efbc00622bdcedbfd1083a37769c361b6 on hpcloud:hpe/build_constraint_fix into 67139b9485d6fd682c5314e963b0915e18f7947a on rackspace:master.