Improve identity v3 support

rackspace / gophercloud

A Go SDK for OpenStack. IN FEATURE FREEZE. See Issue #592

http://gophercloud.io

Other

456 stars 181 forks source link

Improve identity v3 support #593

Closed sbourlon closed 8 years ago

sbourlon commented 8 years ago

OpenStack identity v3 instroduced domains which I added in this PR

Add project domain and domain scoping
Add user domain
Add default domain in case the domain scope and the user domain are the same

Please, let me know if I am missing something or if this PR needs to be improved.

coveralls commented 8 years ago

Coverage decreased (-0.07%) to 80.87% when pulling d9fef25fa7e71f0da9855497a0a61eb7fe1f7767 on sbourlon:improve-identity-v3-support into d47105ce4ef90cea9a14b85c8dd172b760085828 on rackspace:master.

jrperritt commented 8 years ago

Thank you for the PR, but this repo is currently in feature-freeze mode. See #592

sbourlon commented 8 years ago

Thanks @jrperritt for the update. Would it still be possible to merge the PR after the feature-freeze mode is done?

jrperritt commented 8 years ago

Would it still be possible to merge the PR after the feature-freeze mode is done?

In this repo, no. In gophercloud/gophercloud, yes. The public APIs are nearly identical and compatible with one another. As in, almost all code using this library can switch to using the new library with a single gofmt command replacing the import lines, and it should just work. For code that does require changes, I'd expect them to be minor ones.

sbourlon commented 8 years ago

Thanks. I will test the PR against the new repo and sent a new PR to gophercloud/gophercloud.

jrperritt commented 8 years ago

Before you start, please read the description of #592 in its entirety. The new repo won't accept PRs until the contributing guide is updated and the API stabilized. You can track issue #592 for updates on the migration and status of the new repo.

jrperritt commented 8 years ago

Closing this. Hopefully we'll see it in the new repo

fatmcgav commented 7 years ago

@sbourlon / @jrperritt Any joy with making these changes against gophercloud/gophercloud?

jtopjian commented 7 years ago

@sbourlon @fatmcgav While reviewing https://github.com/hashicorp/terraform/pull/7041, I spent the past few evenings looking over the current gophercloud/gophercloud v3 implementation and I think everything is already in place. I even went as far as re-implementing the scoping portion of this PR and saw that the end result was the same.

While there is no direct support for OS_PROJECT_DOMAIN_*, OS_USER_DOMAIN_*, and OS_DEFAULT_DOMAIN, by using the correct combinations of User*, Domain*, and Project*, you can achieve the correct scoping.

However, I could be wrong. If so, can someone please provide an example of where scoping still needs work in the new Gophercloud repository?

fatmcgav commented 7 years ago

@jtopjian I'm inclined to agree, as I've been running TF using the latest code and using domain and project scoping quite happily.

Cheers Gav